New service for adding systems to an entity #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
…ign-gazebo into server-config-root-dom
…bo into use_sdf_plugin
Signed-off-by: Nate Koenig <[email protected]>
…bo into use_sdf_plugin
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
added 2 commits
June 8, 2022 05:12
Signed-off-by: Nate Koenig <[email protected]>
chapulina
suggested changes
Jun 14, 2022
There was a problem hiding this comment.
Did a first pass, the functionality works for me. Tested manually like this, for some fun results:
ign gazebo shapes.sdf -v 4 -r &
ign service -s /world/shapes/entity/system/add --reqtype ignition.msgs.EntityPlugin_V --reptype ignition.msgs.Boolean --timeout 3000 --req 'entity: {id: 1}, plugins: {name: "ignition::gazebo::systems::Buoyancy", filename: "ignition-gazebo-buoyancy-system"}'
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
iche033
force-pushed
the
entity_system_add
branch
from
f3f340b to
1e22d2c
Compare
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
iche033
force-pushed
the
entity_system_add
branch
from
a05f06b to
4695b88
Compare
Signed-off-by: Ian Chen <[email protected]>
9 tasks
chapulina
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
LGTM, let's just wait for #1352 to be merged first.
We also need an ign-msgs8 release with gazebosim/gz-msgs#261, I started a forward-port so we get more into the release: gazebosim/gz-msgs#264
chapulina
removed
the
needs upstream release
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1524 +/- ##
============================================
Coverage 63.96% 63.96%
============================================
Files 317 317
Lines 25584 25613 +29
============================================
+ Hits 16364 16383 +19
- Misses 9220 9230 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Adds a service for adding systems / plugins to an entity at run time. The service accepts the new
EntityPlugin_V.protomsg introduced in gazebosim/gz-msgs#261 that contains the entity id and an array of plugins / systems to add to the entity.Test it
Run the
INTEGRATION_entity_systemtest. It adds thediff_driveplugin to a vehicle model and verifies that it starts moving after the plugin is added.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.